Make Select reset slice length #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cespare
approved these changes
Aug 12, 2021
gayoungpark
force-pushed
the
gpark.sqlx.reset-slice
branch
from
dfc2c28
to
5287c82
Compare
gayoungpark
pushed a commit
that referenced
this pull request
Aug 19, 2021
Remove wrong comment in code example in readme
gayoungpark
force-pushed
the
gpark.sqlx.reset-slice
branch
from
5287c82
to
421d1cd
Compare
|
I'm going to close this PR since it's served it's purpose for code review and for opening jmoiron#767. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://www.pivotaltracker.com/story/show/178404306.
This fixes issue jmoiron#744 by changing sqlx's Select function to reset slices before appending to them.