Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clayui.com): Fix links that pointed to APITable but didn't work #3275

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

kresimir-coko
Copy link
Member

Fixes #3228

Hey @bryceosterhaus can you please review this.

I've done the following as part of this PR:

  • Add id="api-${key}" to the tr that's being constructed by the gatsby-remark-api-table plugin
  • Add all the DatePicker subcomponents to the APITable of DatePicker because some of them were being referenced so I assumed that was the right course
    • Note: most of these are missing descriptions/JSDoc
  • Reword a couple sentences in Button and Date Picker to match these, now fixed, links to API props

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 035d912:

Sandbox Source
ecstatic-meninsky-xvj09 Configuration
tender-currying-546vt Configuration

@kresimir-coko
Copy link
Member Author

Hey @matuzalemsteles I've removed the DatePicker APITables and a couple links that aren't pointing anywhere because they were referencing props from the APITables we don't wanna show.

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think that afterward, we can dedicate some time to better investigate the API generator to support interfaces with references to other components and files, I think we have a lot of APIs that are missing due to this problem.

@kresimir-coko
Copy link
Member Author

@bryceosterhaus I think this is ready to be merged, in case you forgot ❤️

@bryceosterhaus bryceosterhaus merged commit 64993d4 into liferay:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to API Table rows on clayui.com don't lead anywhere
3 participants