feat(macho): allow to create DynamicSymbolCommand in Python #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainthomas
requested changes
Jun 9, 2023
| @@ -48,6 +48,8 @@ class LIEF_API DynamicSymbolCommand : public LoadCommand { | |||
|
|
|||
| DynamicSymbolCommand(const details::dysymtab_command& cmd); | |||
|
|
|||
| static DynamicSymbolCommand createForPython(); | |||
There was a problem hiding this comment.
Core header files should not expose Python specific function :)
|
Let me know if 1a69a1b would be ok. |
|
ping @LouisBrunner |
|
Hey, sorry for the delay. It's not possible for me to test running an actual binary without all the other changes for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a static function (
createForPython) to avoid messing with the implementation of the default constructor.