Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DEBUG enum variants #1053

Closed

Conversation

lelandjansen
Copy link

@lelandjansen lelandjansen commented May 3, 2024

Many C++ build systems define DEBUG=1 to signify when they're building in debug mode. Variables, enum variants, etc. named DEBUG are subject to this macro substitution, get renamed to 1, and fail to compile. This PR renames DEBUG enum variants to a similar name that doesn't get substituted by the preprocessor.

Test plan

mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release ..
cmake --build . --target LIB_LIEF --config Release

@lelandjansen lelandjansen changed the title [wip] Rename DEBUG enum variants Rename DEBUG enum variants May 3, 2024
@lelandjansen lelandjansen changed the title Rename DEBUG enum variants [WIP] Rename DEBUG enum variants May 3, 2024
@lelandjansen lelandjansen changed the title [WIP] Rename DEBUG enum variants Rename DEBUG enum variants May 3, 2024
@romainthomas
Copy link
Member

Looks good, I'll take a closer CI-review in two days!

@romainthomas
Copy link
Member

@lelandjansen thank you for your PR. I did some update on the Python side and I merged through ef824c7

@lelandjansen
Copy link
Author

Thank you @romainthomas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants