Resolve #1055

lief-project · May 6, 2024 · 807b257 · 807b257
1 parent 132ac2d
commit 807b257
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/MachO/Section.cpp b/src/MachO/Section.cpp
@@ -117,7 +117,6 @@ void Section::swap(Section& other) {
 
 }
 
-
 Section::Section(std::string name) {
   this->name(std::move(name));
 }
@@ -136,6 +135,10 @@ span<const uint8_t> Section::content() const {
     return {};
   }
 
+  if (int64_t(size_) < 0 || int64_t(offset_) < 0) {
+    return {};
+  }
+
   uint64_t relative_offset = offset_ - segment_->file_offset();
   span<const uint8_t> content = segment_->content();
   if (relative_offset > content.size() || (relative_offset + size_) > content.size()) {

diff --git a/tests/macho/test_generic.py b/tests/macho/test_generic.py
@@ -280,3 +280,9 @@ def test_twolevel_hints():
 def test_overlay():
     sample = lief.MachO.parse(get_sample("MachO/overlay_data.bin")).at(0)
     assert bytes(sample.overlay) == b'\x00overlay data'
+
+def test_issue_1055():
+    sample = lief.MachO.parse(get_sample("MachO/issue_1055.bin")).at(0)
+    for section in sample.sections:
+        size = len(section.content)
+        assert size is not None