Add unit-tests for Math #775
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loga4
reviewed
Jun 27, 2023
contracts/0.8.9/lib/Math.sol
Outdated
| @@ -15,6 +15,8 @@ library Math { | |||
|
|
|||
| /// @notice Tests if x ∈ [a, b) (mod n) | |||
| /// | |||
| /// It is known that this function is susceptable to underflow/overflow/division-by-zero if | |||
| /// intending to use in an unchecked context, be considerate of these possibilities | |||
| function pointInHalfOpenIntervalModN(uint256 x, uint256 a, uint256 b, uint256 n) | |||
There was a problem hiding this comment.
Lido does not use these functions, and since they contain potential problems, I suggest removing them from the library at all (and tests too).
There was a problem hiding this comment.
It's an interesting proposal 🤔
The bytecode of the contracts will remain the same (because the compiler doesn't emit a bytecode for the unused library functions unless referenced somehow in the code). However, we would need to re-verify the sources on Etherscan.
There was a problem hiding this comment.
removed both the implementation and the associated tests for the unused function.
claudijd
force-pushed
the
add_math_tests
branch
from
0e400e9
to
df4d875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds forge unit-tests for the Math.sol implementation and additionally adds comments