New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: shapella upgrade followups #624
Merged
TheDZhon
merged 252 commits into
feature/shapella-upgrade
from
feature/shapella-upgrade-followups
Feb 21, 2023
Merged
Feat: shapella upgrade followups #624
TheDZhon
merged 252 commits into
feature/shapella-upgrade
from
feature/shapella-upgrade-followups
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts-accounting-oracle-handlers-refactor test: AccountingOracle submit extra data handlers refactor
…eature/nonzero_shares_and_tvl
…o into feature/nor-optimize
NOR: static totals storage
Fix module rewards distribution
…NFT for WithdrawalQueueERC721✨
NFTDescriptor for WithdrawalQueueERC721
fix: comments and docs 📚
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cumulative PR headed to #482 (on top of 2.0.0-beta)
High-level overview:
NodeOperatorRegistry
and report stuck / exited keys in a gas-efficient way (avoid nested loops)unaccountedEther
whendeposit
is made andStakingRouter
had non-zero balanceWithdrawalQueueERC721
) edge-cases and ownership issuesValidatorExitBus
Contents
MAX_NODE_OPERATORS_COUNT
reward distribution gas for NodeOperatorsRegistry #622handleOracleReport
and shares burning #636