Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: shapella upgrade followups #624

Merged
merged 252 commits into from Feb 21, 2023

Conversation

TheDZhon
Copy link
Contributor

@TheDZhon TheDZhon commented Feb 16, 2023

Cumulative PR headed to #482 (on top of 2.0.0-beta)

High-level overview:

  • Seed initial protocol holder to avoid zero total supply / zero total shares corner cases
  • Collect summary from NodeOperatorRegistry and report stuck / exited keys in a gas-efficient way (avoid nested loops)
  • Resolve No check for report in submitReportData #634
  • Resolve an accounting issue with unaccountedEther when deposit is made and StakingRouter had non-zero balance
  • Fixes withdrawal request NFT (now it's WithdrawalQueueERC721) edge-cases and ownership issues
  • Make stETH permit signing for the token address
  • Enforces the validator indexes order in ValidatorExitBus
  • Internal comments and minor naming updates
  • Add public views for unstaking UI

Contents

bulbozaur and others added 30 commits February 14, 2023 01:21
…ts-accounting-oracle-handlers-refactor

test: AccountingOracle submit extra data handlers refactor
krogla and others added 27 commits February 21, 2023 12:31
NFTDescriptor for WithdrawalQueueERC721
@TheDZhon TheDZhon marked this pull request as ready for review February 21, 2023 15:02
@TheDZhon TheDZhon merged commit e575177 into feature/shapella-upgrade Feb 21, 2023
@TheDZhon TheDZhon deleted the feature/shapella-upgrade-followups branch February 21, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet