Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify Tx with Ancestry - replaces SPV Envelope #37

Merged
merged 14 commits into from Dec 15, 2021
Merged

Verify Tx with Ancestry - replaces SPV Envelope #37

merged 14 commits into from Dec 15, 2021

Commits on Dec 14, 2021

  1. build the verify function from an ancestry perspective 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    567e487 View commit details
    Browse the repository at this point in the history

  2. fix test data to reflect 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    4579261 View commit details
    Browse the repository at this point in the history

  3. redundant string() conversion 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    3e77f19 View commit details
    Browse the repository at this point in the history

  4. remove parseChunk and replcae with NewTxFromStream() 

    requires corresponding change removing VarInt length prefix in Byte() function

Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    c29088e View commit details
    Browse the repository at this point in the history

  5. Bytes() expecting no lngth for txs 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    02ba1e3 View commit details
    Browse the repository at this point in the history

  6. update hex test data with new format. 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    4d3eb54 View commit details
    Browse the repository at this point in the history

  7. fix test data in json examples 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    2242b1f View commit details
    Browse the repository at this point in the history

  8. contexts must be passed in rather than just created within a function 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    020344e View commit details
    Browse the repository at this point in the history

  9. Rename flake, name inputs to verify with ancestry, remove verifypayme… 

    …nt from interface

Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    cd6a891 View commit details
    Browse the repository at this point in the history

  10. missing package 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    6649159 View commit details
    Browse the repository at this point in the history

  11. Revert "fix test data in json examples" 

    This reverts commit 2242b1f.

We are reverting to using VarInts in front of flagTx types now too.

Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    e73f8e7 View commit details
    Browse the repository at this point in the history

  12. The missing dataLength 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    ade9f99 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. tigh review fixes 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    ece147a View commit details
    Browse the repository at this point in the history

  2. renaming parameters to rawtx and moving the json array up a level. 

    Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
    Darren Kellenschwiler committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    feeff5a View commit details
    Browse the repository at this point in the history