Verify Tx with Ancestry - replaces SPV Envelope #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadwahab
reviewed
Dec 13, 2021
jadwahab
reviewed
Dec 13, 2021
jadwahab
reviewed
Dec 13, 2021
jadwahab
reviewed
Dec 13, 2021
jadwahab
reviewed
Dec 13, 2021
added 10 commits
December 14, 2021 08:19
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
requires corresponding change removing VarInt length prefix in Byte() function Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
…nt from interface Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
sirdeggen
force-pushed
the
feat/implement-ancestor-verification-remove-varint
branch
from
f4b6a37
to
6649159
Compare
added 2 commits
December 14, 2021 08:26
This reverts commit 2242b1f. We are reverting to using VarInts in front of flagTx types now too. Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
tigh-latte
suggested changes
Dec 15, 2021
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
tigh-latte
approved these changes
Dec 15, 2021
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
mergify
bot
deleted the
feat/implement-ancestor-verification-remove-varint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually using the functions for verification created in a previous PR.