transport: Add option to set ECN on the TransportSender socket. #685
Conversation
|
Hello everyone! Thank you for such an awesome library! It does exactly what I needed, and then I found that I had one feature I desired, so I added it: the option for setting the ecn bits. I know that my PR does not have tests ... however, if this is a feature you would like to have, I am more than happy to add tests. I just didn't want to spam you with something unless you thought it was useful! Thank you for your dedication to keeping up this awesome crate. And, yes, I will fix the CI/CD. Sorry! Thank you again! |
I think I fixed as much of the CI/CD as I can without venturing too far afield of what this PR does. Let me know what else I can do! Thank you! |
|
I like this!!! Congestion Notification. is very important Testing this locally right now. Most of the fail checks I had before were due to spelling errors and such so shouldn't worry you too much. If this is merged all should be good #676. Testing locally to see if there is anything else that might be amiss. |
I sincerely, sincerely appreciate your enthusiasm. As I said, this crate is amazing. If there is anything else I can do to help, please just let me know!
|
|
Just dropping in to add a little feature that I found that I needed -- implementing the |
Add support for setting the ECN bits on a TransportSender socket for IPv4 and IPv6. Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
|
In earlier versions of the PR, I had improperly labeled the constants associated with the ECT values. In the most recently update to the PR, that is now fixed! Sorry! Thanks again for all that you do! |
|
I'd have liked some documentation to go with this, but I'll not hold up merging it since you've been waiting long enough :) Thank you for your contribution. |
Add support for setting the ECN bits on a TransportSender socket for IPv4 and IPv6.