linux: use poll api instead of select inorder to support fd > 1024. Fixes #612 and #639 #681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the usage of
select
withpoll
on linux.select
has a limitation that the number of descriptors and the actual descriptor value must be lower thanFD_SETSIZE
which is 1024[1]. The number of descriptor isn't an issue, however if a socket is created that has an FD that is greater than 1024, this will causelibc::FD_SET
to panic.To fix this, instead of using
select
, we can usepoll
.poll
does not have this limitation. This PR replaceslibc::pselect
withlibc::poll
This fixes #612 and #639.
[1] https://linux-tips.com/t/is-it-possible-to-listen-file-descriptor-greater-than-1024-with-select/45