datalink(linux): add feature to pass the fd (socket) to ::channel() #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmonday
requested changes
Feb 3, 2023
This can be useful if the caller want to manipulate the socket differently at creating. For example setting a BPF filter on the socket before passing it in the channel: ``` datalink::linux::channel(interface, config, socket_fd) ``` Signed-off-by: Martin Andre <martin.andre@tessares.net>
|
Hey @mrmonday , sorry for the very very late reply and update on this. Just came back to this and still think this can be helpful to have in the lib. The tests failing seems to not be linked with the change, can they be ignored? Or any idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful if the caller want to manipulate the socket differently at creating.
For example setting a BPF filter on the socket before passing it in the channel:
Signed-off-by: Martin Andre martin.andre@tessares.net