Issue 487

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,32 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: "[BUG]"
+labels: Bug
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps of Code to reproduce the behavior:
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Error Snippet**
+If applicable, add screenshots or snippets to help explain your problem.
+
+**Environment (please complete the following information):**
+ - OS: [e.g. Windows, Mac, Linux]
+ - Version [e.g. 10, 12.3.1, Buster]
+
+**Rust Environment (please complete the following information):**
+ - Version: [e.g. 1.60.0]
+ - Toolchain: [e.g. stable-x86_64-unknown-linux-gnu, nightly-x86_64-apple-darwin]
+ - Version of Libpnet [e.g. 0.27.1, 0.29.0]
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: "[Feature]"
+labels: Feature Request
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/workflows/ci.yml

@@ -2,9 +2,9 @@ name: Rust
 
 on:
   push:
-    branches: [ master ]
+    branches: [ main ]
   pull_request:
-    branches: [ master ]
+    branches: [ main ]
 
 env:
   CARGO_TERM_COLOR: always

pnet_base/src/macaddr.rs

@@ -30,11 +30,13 @@ pub struct MacAddr(pub u8, pub u8, pub u8, pub u8, pub u8, pub u8);
 
 impl MacAddr {
     /// Construct a new `MacAddr` instance.
+    #[inline]
     pub fn new(a: u8, b: u8, c: u8, d: u8, e: u8, f: u8) -> MacAddr {
         MacAddr(a, b, c, d, e, f)
     }
 
     /// Construct an all-zero `MacAddr` instance.
+    #[inline]
     pub fn zero() -> MacAddr {
         Default::default()
     }
@@ -78,21 +80,25 @@ impl MacAddr {
     pub fn octets(&self) -> [u8; 6] {
         [self.0, self.1, self.2, self.3, self.4, self.5]
     }
+
 }
 
 impl From<EtherAddr> for MacAddr {
+    #[inline]
     fn from(addr: EtherAddr) -> MacAddr {
         MacAddr(addr[0], addr[1], addr[2], addr[3], addr[4], addr[5])
     }
 }
 
 impl From<MacAddr> for EtherAddr {
+    #[inline]
     fn from(addr: MacAddr) -> Self {
         [addr.0, addr.1, addr.2, addr.3, addr.4, addr.5]
     }
 }
 
 impl PartialEq<EtherAddr> for MacAddr {
+    #[inline]
     fn eq(&self, other: &EtherAddr) -> bool {
         *self == MacAddr::from(*other)
     }
@@ -114,6 +120,7 @@ impl Serialize for MacAddr {
     ///
     /// It serializes either to a string or its binary representation, depending on what the format
     /// prefers.
+    #[inline]
     fn serialize<S: Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
         if serializer.is_human_readable() {
             serializer.collect_str(self)
@@ -130,15 +137,18 @@ impl<'de> Deserialize<'de> for MacAddr {
     /// It deserializes it from either a byte array (of size 6) or a string. If the format is
     /// self-descriptive (like JSON or MessagePack), it auto-detects it. If not, it obeys the
     /// human-readable property of the deserializer.
+    #[inline]
     fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
         struct MacAddrVisitor;
         impl<'de> de::Visitor<'de> for MacAddrVisitor {
             type Value = MacAddr;
 
+            #[inline]
             fn visit_str<E: de::Error>(self, value: &str) -> Result<MacAddr, E> {
                 value.parse().map_err(|err| E::custom(err))
             }
 
+            #[inline]
             fn visit_bytes<E: de::Error>(self, v: &[u8]) -> Result<MacAddr, E> {
                 if v.len() == 6 {
                     Ok(MacAddr::new(v[0], v[1], v[2], v[3], v[4], v[5]))
@@ -147,6 +157,7 @@ impl<'de> Deserialize<'de> for MacAddr {
                 }
             }
 
+            #[inline]
             fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
                 write!(
                     formatter,
@@ -202,6 +213,7 @@ impl fmt::Display for ParseMacAddrErr {
 
 impl FromStr for MacAddr {
     type Err = ParseMacAddrErr;
+    #[inline]
     fn from_str(s: &str) -> Result<MacAddr, ParseMacAddrErr> {
         let mut parts = [0u8; 6];
         let splits = s.split(':');