Update stream limits and connection limits #53
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…update-stream-limits
…update-stream-limits
…update-stream-limits
p-shahi
changed the title
| // these are set because we were seeing a lot of identify and identify push | ||
| // stream limits being hit | ||
| maxPushOutgoingStreams: 1000, | ||
| maxPushIncomingStreams: 1000, | ||
| maxInboundStreams: 1000, | ||
| maxOutboundStreams: 1000, |
There was a problem hiding this comment.
I am concerned by this. These limits are per connection, this means you're allowing 1000 identify streams to be open at the same time on each connection.
If you're seeing errors it sounds like something's not cleaning up the streams.
Maybe related: libp2p/js-libp2p#1424
There was a problem hiding this comment.
Do what you have to to appease the demo gods though - this is more of a note to self to investigate.
There was a problem hiding this comment.
Yeah the upper bounds here are crazy, but we were hitting the limits quite often so set it arbitrarily high
packages/frontend/src/lib/libp2p.ts
Outdated
| connectionManager: { | ||
| maxConnections: 200, | ||
| minConnections: 1, | ||
| maxConnections: 10, | ||
| minConnections: 50, | ||
| }, |
There was a problem hiding this comment.
minConnections needs to be less than maxConnections.
Is there a reason you're overriding this? If not I'd just remove the whole connectionManager block.
There was a problem hiding this comment.
removed, I'm not sure why it was added. @maschad any idea?
No description provided.