-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ping/rust: remove the master dependency #45
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,8 +11,8 @@ use testground::network_conf::{ | |
}; | ||
|
||
pub mod libp2p { | ||
#[cfg(all(feature = "libp2pv0480",))] | ||
pub use libp2pv0480::*; | ||
#[cfg(all(feature = "libp2pmaster",))] | ||
pub use libp2pmaster::*; | ||
|
||
#[cfg(all(feature = "libp2pv0470",))] | ||
pub use libp2pv0470::*; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (creating here to get a thread) @mxinden, I'm trying to catch other cases where the build might break after a push to
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Correct. Though this will change soon where we can replace all the features with a single There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I am not sure I follow. Once a crate is published to crates.io it can never be changed again. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apologies, I mixed versions and packages which is unclear, I'm wondering if there are other cases where a push to rust-libp2p master branch can break the build for previous versions of the ping test (
Trying to play around with macro it looks like it's enough, but I might miss some rust's edge cases. // cargo build --features libp2pmaster (FAIL)
// cargo build --features libp2pv2 (OK)
fn main() {
println!("got: {}", s() + 1)
}
#[cfg(all(feature = "libp2pmaster",))]
fn s() -> String {
return String::from("new master API that breaks the current helloworld test");
}
#[cfg(all(feature = "libp2pv2",))]
fn s() -> i32 {
return 2;
} |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw this change while working on #42. Was this a temporary change because until #42 is merged we are not compatible with the master branch, or should I also use a concrete revision there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just released
testground
v0.4.0
. How about using that instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testground/sdk-rust#38