Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping/_composition/go.toml: disable go custom & master branches #30

Conversation

laurentsenta
Copy link
Collaborator

@laurentsenta laurentsenta commented Aug 22, 2022

We disabled interop tests in go-libp2p which means that the go-libp2p team might break the interoperability testing at any time.

That's a problem when it comes to interoperability testing: if we enable interop testing in rust, maintainers will experience random breakage in the CI because of the other repo. We can only play catch-up with the go-side until we re-enable the interop tests there.

This PR disables go's master and custom tests until we fix the stability / caching issues and reenable the tests in go-libp2p.

Related issues & PR

current go status

The tests started breaking after we moved go-libp2p-core into go-libp2p/core. It breaks every versions at the moment (work in progress branch).

@laurentsenta
Copy link
Collaborator Author

@mxinden @marten-seemann are we fine with this?
I'd like to make sure we're happy to merge libp2p/rust-libp2p#2835 and start getting some stability feedback from the rust side too.

@marten-seemann
Copy link
Contributor

This would be a sad outcome. I didn't mean to break our interop testing story when I disabled the tests, but the flakiness was holding us back from making progress. Do we have any timeline for a more stable version of the test setup?

@laurentsenta
Copy link
Collaborator Author

@marten-seemann It really depends on your definition of "good enough" (#29 (comment))

If you're fine with ~25 min of CI time (#29), we add retries and re-enable the go cross versions tests by tomorrow.

If you need ~20 min of CI time, we add retries, and improve testground setup (should take less than a week, testground/testground#1371), then re-enable the go cross versions tests.

If you need less, we implement caching with #31 (should take a week or two) then improve testground setup (a week). We might get the cross-version AND cross-implementation testing below the 10 minutes bar.

@laurentsenta
Copy link
Collaborator Author

By the way, it's not ideal, but I think it's fine to disable the go master test if it means we can get some workload on the rust side. It will help with stability work more than if we're not running rust at all.

@laurentsenta
Copy link
Collaborator Author

Replaced by #32

@laurentsenta laurentsenta deleted the disable-ping-go-master-and-current branch August 29, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants