kad-dht/README: Document key on Message during PUT_VALUE #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On PUT_VALUE the Golang implementation expects `key` on `Message` to equal `key` on `Record` when handling a request (see [go-1]). This patch updates the specification accordingly. [go-1]: https://github.com/libp2p/go-libp2p-kad-dht/blob/7724838e46d1822b28fd20611ab9815d4ce2d94f/handlers.go#L151-L164
|
Friendly ping @aschmahmann. |
1 similar comment
|
Friendly ping @aschmahmann. |
aschmahmann
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Looks right to me, thanks for the PR and the pings 😄
I'm not sure why the decision was made here to echo back the full record, and if we're doing that why not echo back a "better" record if the DHT server has it, but we're just documenting existing protocol behavior here 🤷.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PUT_VALUE the Golang implementation expects
keyonMessagetoequal
keyonRecordwhen handling a request (see go-1). This patchupdates the specification accordingly.
Caught by @pradt2 see libp2p/rust-libp2p#2309.