Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: promote futures to workspace dependency #5329

Merged
merged 3 commits into from Apr 27, 2024
Merged

deps: promote futures to workspace dependency #5329

merged 3 commits into from Apr 27, 2024

Conversation

drHuangMHT
Copy link
Contributor

Description

Promote futures to workspace dependency for easier management.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@jxs
Copy link
Member

jxs commented Apr 27, 2024

huh mergify should have commented here, Thanks @drHuangMHT! Can you address the conflicts?

@drHuangMHT drHuangMHT marked this pull request as ready for review April 27, 2024 12:55
jxs
jxs approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jxs jxs added the send-it label Apr 27, 2024
@mergify mergify bot merged commit 954c967 into libp2p:master Apr 27, 2024
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drHuangMHT @jxs