deps: deduplicate dependencies #5318
Conversation
Signed-off-by: onur-ozkan <work@onurozkan.dev>
transports/uds/Cargo.toml
Outdated
| @@ -18,7 +18,7 @@ tokio = { workspace = true, default-features = false, features = ["net"], option | |||
| tracing = { workspace = true } | |||
|
|
|||
| [dev-dependencies] | |||
| tempfile = "3.10" | |||
| tempfile = "3.6" | |||
There was a problem hiding this comment.
Are we okay with this downgrade? I think it should be fine since it's a dev-dependency.
There was a problem hiding this comment.
Hi, and thanks for your interest! As we use dependabot to submit PR's with updates for the dependencies I don't think this is worth it.
If we downgrade tempfile dependabot will submit a PR trying to update it afaik, trying to keep track of downgraded packages and keeping ignoring upgrades for certain so that we have less package versions on Cargo.lock is therefore not worth it imho.
Only the 2nd commit downgrades a dependency as pointed out at #5318 (comment). I will revert that commit since the repo has dependabot integration. |
onur-ozkan
force-pushed
the
reduce-dependencies
branch
from
f26da41
to
2d9c41c
Compare
Description
Helps to reduce number of dependencies by removing duplicated ones.