Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrohacker/ring@0.17.8 #5316

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

retrohacker
Copy link

@retrohacker retrohacker commented Apr 17, 2024

Description

This PR updates the following dependencies:

  • identify
    • ring@0.17.5 -> ring@0.17.8
  • quic
    • quin@0.10.2 -> unreleased
    • rustls@0.21.9 -> rustls@0.23.4
    • ring@0.16.20 -> ring@0.17.8
  • tls
    • futures-rustls@0.24.0 -> futures-rustls@0.26.0
    • ring@0.16.20 -> ring@0.17.8
    • rustls@0.21.9 -> rustls@0.23.4
  • websocket
    • futures-rustls@0.24.0 -> futures-rustls@0.26.0

Replaces/Discussed: #4706
Depends on: quinn-rs/quinn#1715

Notes & open questions

The new rustls types now use borrowed references by default and require you to take ownership of them by cloning explicitly (gated behind the alloc feature).

I'm not very good with rust lifetimes and I don't think I'm approaching them correctly in this PR. The <'static> seems wrong for example.

While working on this PR, I noticed the max_bytes, max_percentages tests are flakey on my machine. They both fail for me intermittently on the master branch.

I have them commented out right now for local dev but they need to be added back in before merge.

I also believe this is a breaking change since we seem to expose rustls.

quinn has not yet released support for rustls@0.23 or ring@0.17, I'm referencing it as a git dependency until their PR is merged.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link

mergify bot commented Apr 17, 2024

This pull request has merge conflicts. Could you please resolve them @retrohacker? 🙏

@retrohacker
Copy link
Author

quinn PR merged, waiting on .11 release: quinn-rs/quinn#1737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant