Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the following dependencies:
identify
ring@0.17.5
->ring@0.17.8
quic
quin@0.10.2
-> unreleasedrustls@0.21.9
->rustls@0.23.4
ring@0.16.20
->ring@0.17.8
tls
futures-rustls@0.24.0
->futures-rustls@0.26.0
ring@0.16.20
->ring@0.17.8
rustls@0.21.9
->rustls@0.23.4
websocket
futures-rustls@0.24.0
->futures-rustls@0.26.0
Replaces/Discussed: #4706
Depends on: quinn-rs/quinn#1715
Notes & open questions
The new rustls types now use borrowed references by default and require you to take ownership of them by cloning explicitly (gated behind the
alloc
feature).I'm not very good with rust lifetimes and I don't think I'm approaching them correctly in this PR. The
<'static>
seems wrong for example.While working on this PR, I noticed the
max_bytes
,max_percentages
tests are flakey on my machine. They both fail for me intermittently on the master branch.I have them commented out right now for local dev but they need to be added back in before merge.
I also believe this is a breaking change since we seem to expose rustls.
quinn
has not yet released support forrustls@0.23
orring@0.17
, I'm referencing it as a git dependency until their PR is merged.Change checklist