Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require rand feature when generating ecdsa key #5212

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Rjected
Copy link

@Rjected Rjected commented Mar 6, 2024

Description

Using libp2p-identity as a crate did not work if default-features is false and ecdsa is included.

The following command also fails:

cargo check --no-default-features --features "ecdsa,ed25519,peerid,secp256k1"

Now, this command works

Notes & open questions

Found this when trying to install enr-cli:

cargo install enr-cli

Bumped the version so it can be bumped in any crates that depend on it such as enr-cli

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@Rjected Rjected changed the title fix: require rand feature generating ecdsa key fix: require rand feature when generating ecdsa key Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant