Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rz): emit NewExternalAddrOfPeer when discovering peers #5138

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dariusc93
Copy link
Contributor

Description

Notes & open questions

  1. Do we want to check to determine if a peer has been previously discovered so we dont return the event for the same peer and address or should we continue to emit the event event even if the peer has been previously discovered and registration havent expired?

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger
Copy link
Contributor

Do we want to check to determine if a peer has been previously discovered so we dont return the event for the same peer and address or should we continue to emit the event event even if the peer has been previously discovered and registration havent expired?

Yeah, I think we should check that by subscribing to the relevant events and only emitting an event if we find a new peer. That way, event traffic between the behaviours is reduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rendezvous: emit ToSwarm::NewExternalAddrOfPeer
2 participants