Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webrtc example): clarify idle connection timeout #4966

Merged
merged 10 commits into from
Dec 5, 2023
2 changes: 2 additions & 0 deletions examples/browser-webrtc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ It uses [wasm-pack](https://rustwasm.github.io/docs/wasm-pack/) to build the pro

## Running the example

Ensure you have `wasm-pack` [installed](https://rustwasm.github.io/wasm-pack/).

1. Build the client library:
```shell
wasm-pack build --target web --out-dir static
Expand Down
4 changes: 3 additions & 1 deletion examples/browser-webrtc/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ pub async fn run(libp2p_endpoint: String) -> Result<(), JsError> {
webrtc_websys::Transport::new(webrtc_websys::Config::new(&key))
})?
.with_behaviour(|_| ping::Behaviour::new(ping::Config::new()))?
.with_swarm_config(|c| c.with_idle_connection_timeout(Duration::from_secs(5)))
// Ping does not KeepAlive, so we set the idle connection timeout to 32_212_254u64,
thomaseizinger marked this conversation as resolved.
Show resolved Hide resolved
// which is the largest value that works with the wasm32 target.
.with_swarm_config(|c| c.with_idle_connection_timeout(Duration::from_secs(32_212_254u64)))
.build();

let addr = libp2p_endpoint.parse::<Multiaddr>()?;
Expand Down
2 changes: 1 addition & 1 deletion examples/browser-webrtc/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ async fn main() -> anyhow::Result<()> {
.with_behaviour(|_| ping::Behaviour::default())?
.with_swarm_config(|cfg| {
cfg.with_idle_connection_timeout(
Duration::from_secs(30), // Allows us to observe the pings.
thomaseizinger marked this conversation as resolved.
Show resolved Hide resolved
Duration::from_secs(u64::MAX), // Allows us to observe the pings.
)
})
.build();
Expand Down