Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(identity): update ed25519-dalek to 2.0 #4365

Merged
merged 4 commits into from Aug 23, 2023
Merged

deps(identity): update ed25519-dalek to 2.0 #4365

merged 4 commits into from Aug 23, 2023

Conversation

altonen
Copy link

@altonen altonen commented Aug 21, 2023 •
edited by thomaseizinger

Description

Fixes #4327 for the v0.51 release.
Related: #4337.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

jxs and others added 2 commits August 18, 2023 08:04
@jxs @mergify
deps(identity): update ed25519-dalek to 2.0
7266eb7 
Pull-Request: #4337.
(cherry picked from commit fb61697)

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	identity/CHANGELOG.md
#	identity/Cargo.toml
@altonen
Backport rust-libp2p#4337 to 0.51
c349c55
@altonen altonen changed the title Backport 4337 to 0.51 deps(identity): update ed25519-dalek to 2.0 (backport #4337) Aug 21, 2023
thomaseizinger
thomaseizinger requested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll need to reduce this in scope, both to be as minimal as possible and for it to actually be releasable as patch.

Cargo.toml Outdated Show resolved Hide resolved
core/Cargo.toml Outdated Show resolved Hide resolved
identity/Cargo.toml Outdated Show resolved Hide resolved
identity/Cargo.toml Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title deps(identity): update ed25519-dalek to 2.0 (backport #4337) deps(identity): update ed25519-dalek to 2.0 Aug 21, 2023
mxinden
mxinden reviewed Aug 21, 2023
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

@mxinden mxinden merged commit 113bca9 into libp2p:v0.51 Aug 23, 2023
20 of 60 checks passed
@mxinden
Copy link
Member

mxinden commented Aug 23, 2023

Tagged and published.

//CC @altonen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@altonen @mxinden @thomaseizinger @jxs