Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dcutr): reshape public API to follow naming guidelines #3214

Merged
merged 27 commits into from
Dec 20, 2022
Merged

refactor(dcutr): reshape public API to follow naming guidelines #3214

merged 27 commits into from
Dec 20, 2022

Conversation

thomaseizinger
Copy link
Contributor

Description

With this patch, the naming of types follows the guidelines discussed in #2217.

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mergify
Copy link

mergify bot commented Dec 8, 2022

⚠️ The sha of the head commit of this PR conflicts with #3213. Mergify cannot evaluate rules on this PR. ⚠️

@thomaseizinger
Rename public API symbols
6995ff0 
This follows the guidelines discussed in #2217.
This was referenced Dec 8, 2022
Merged
Open
@thomaseizinger thomaseizinger mentioned this pull request Dec 9, 2022
Merged
4 tasks
Base automatically changed from fix-semver-check-hickup to master December 14, 2022 23:40
@thomaseizinger thomaseizinger mentioned this pull request Dec 14, 2022
Merged
4 tasks
@thomaseizinger thomaseizinger marked this pull request as ready for review December 14, 2022 23:59
mxinden
mxinden approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thank you!

@thomaseizinger
Copy link
Contributor Author

@Mergifyio queue

@mergify
Copy link

mergify bot commented Dec 20, 2022

queue

🛑 The pull request has been removed from the queue

The queue conditions cannot be satisfied due to failing checks or checks timeout.
You can take a look at Queue: Embarked in merge train check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@thomaseizinger
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link

mergify bot commented Dec 20, 2022

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 93335b8 into master Dec 20, 2022
@thomaseizinger thomaseizinger deleted the dcutr-rename-public-api branch February 24, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@jxs jxs Awaiting requested review from jxs

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomaseizinger @mxinden @jxs