-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add link to rustdocs for master
to README
#3197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
changed the title
feat: Add master docs note to README
docs: Add link to rustdocs for Dec 7, 2022
master
to README
thomaseizinger
requested changes
Dec 7, 2022
jxs
reviewed
Dec 8, 2022
thomaseizinger
approved these changes
Dec 9, 2022
elenaf9
previously approved these changes
Dec 10, 2022
Adding |
thomaseizinger
previously approved these changes
Dec 16, 2022
mergify
bot
dismissed stale reviews from thomaseizinger and elenaf9
December 16, 2022 22:04
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
thomaseizinger
previously approved these changes
Dec 16, 2022
mergify
bot
dismissed
thomaseizinger’s stale review
December 17, 2022 17:51
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
thomaseizinger
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a link to the master docs to the README.
Links to any relevant issues
Following #3126.
Open Questions
I added a warning to the libp2p module documentation. This has to be removed before a release. Is this a good solution?
Change checklist