fix(derive): Release breaking change as v0.31.0 #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`libp2p-swarm-derive` released a breaking change (libp2p#3011) as a patch release `v0.30.2`. This patch: 1. Prepares a new minor release of `libp2p-swarm-derive`. 2. Prepares a patch release for `libp2p-swarm` to use the minor release of `libp2p-swarm-derive`. As a follow up we can yank the `libp2p-swarm-derive` `v0.30.2` release. In addition we might want to release `libp2p-swarm-derive` `v0.30.3` containing all patches but libp2p#3011.
mxinden
commented
Nov 29, 2022
| @@ -46,7 +46,7 @@ libp2p-identify = { path = "../protocols/identify" } | |||
| libp2p-kad = { path = "../protocols/kad" } | |||
| libp2p-ping = { path = "../protocols/ping" } | |||
| libp2p-plaintext = { path = "../transports/plaintext" } | |||
| libp2p-swarm-derive = { version = "0.30.2", path = "../swarm-derive" } | |||
There was a problem hiding this comment.
version was introduced in https://github.com/libp2p/rust-libp2p/pull/3055/files#r1034571199. @thomaseizinger was that a deliberate choice or an oversight?
There was a problem hiding this comment.
An oversight! Thanks for fixing it!
I agree. |
thomaseizinger
approved these changes
Nov 29, 2022
jxs
approved these changes
Nov 29, 2022
|
thanks for this Max! |
|
Thanks indeed! I also encountered the issue. |
|
Can we move on here @mxinden? |
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
|
I will publish and tag the release after the libp2p community call. |
|
Ty @mxinden :) |
|
FYI might be worth checking out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
libp2p-swarm-derivereleased a breaking change (#3011) as a patch releasev0.30.2.This patch:
libp2p-swarm-derive.libp2p-swarmto use the minor release oflibp2p-swarm-derive.As a follow up we can yank the
libp2p-swarm-derivev0.30.2release. In addition we might want to releaselibp2p-swarm-derivev0.30.3containing all patches but #3011.See #3176 for corresponding discussion.
Notes
//CC @joao-paulo-parity @dvdplm
Links to any relevant issues
Open Questions
If I am not mistaken, we can release this in
libp2p-swarmas a patch release. Would appreciate additional eyes on that.Change checklist