Cargo.toml: Remove deprecated executor-specific features #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want to emit the deprecation warning in case a user uses the old features and _not_ the new ones. This assumes that a user upgrades properly, i.e. adds the new `tokio` or `async-std` feature AND removes the old `tcp-tokio` feature from the list. We need to use this rather complex cfg expression because otherwise, our CI won't pass. We run clippy with `--all-features`, thus just detecting for presence of the `tcp-async-io` feature for example will always flag our examples as using deprecated code.
Otherwise CI will not pass once #2963 actually checks it properly.
4 tasks
|
Thank you @thomaseizinger! |
|
This is blocked on the |
mxinden
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
@thomaseizinger thanks for preparing this. Can you bump the version in the root level Cargo.toml? Otherwise this looks good to me.
…st-libp2p into 2173-remove-deprecated-feature
mxinden
approved these changes
Oct 19, 2022
|
Interop tests fail for the same reasons as recently: We are bumping the version to 0.50 in this PR but testground doesn't yet know about that. Proceeding with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to any relevant issues
Open Questions
Change checklist
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature works