Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: Deprecate executor specific features for sub-crates #2962

Merged
merged 8 commits into from Oct 11, 2022

Commits on Sep 30, 2022

  1. Configuration menu
    Copy the full SHA
    d26237b View commit details
    Browse the repository at this point in the history
  2. Add changelog entry

    thomaseizinger committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    2dcbe30 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    54c6599 View commit details
    Browse the repository at this point in the history
  4. Feature-gate development_transport correctly

    We only want to emit the deprecation warning in case a user uses
    the old features and _not_ the new ones. This assumes that a user
    upgrades properly, i.e. adds the new `tokio` or `async-std` feature
    AND removes the old `tcp-tokio` feature from the list.
    
    We need to use this rather complex cfg expression because otherwise,
    our CI won't pass. We run clippy with `--all-features`, thus just
    detecting for presence of the `tcp-async-io` feature for example
    will always flag our examples as using deprecated code.
    thomaseizinger committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    830acc1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    09a301f View commit details
    Browse the repository at this point in the history
  6. Include deprecated features in full

    Otherwise CI will not pass once #2963
    actually checks it properly.
    thomaseizinger committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    44b58cc View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Configuration menu
    Copy the full SHA
    89d23bc View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Configuration menu
    Copy the full SHA
    88e262c View commit details
    Browse the repository at this point in the history