Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{core,muxers/mplex}: Fix bad version bump #2960

Merged
merged 3 commits into from Oct 4, 2022
Merged

{core,muxers/mplex}: Fix bad version bump #2960

merged 3 commits into from Oct 4, 2022

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Sep 30, 2022

Description

#2918 had a bad merge commit where we accidentially bumped the version of libp2p-core and libp2p-mplex by a minor AND a patch.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger changed the title core: Fix bad version bump {core, muxers/mplex}: Fix bad version bump Sep 30, 2022
@thomaseizinger thomaseizinger changed the title {core, muxers/mplex}: Fix bad version bump {core,muxers/mplex}: Fix bad version bump Sep 30, 2022
@thomaseizinger thomaseizinger mentioned this pull request Oct 4, 2022
4 tasks
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks for the fix.

@mxinden mxinden merged commit 215a8e1 into master Oct 4, 2022
@thomaseizinger thomaseizinger deleted the core-bad-version branch October 4, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants