Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm-derive/: Derive Debug for generated OutEvent #2821

Merged
merged 4 commits into from Aug 17, 2022
Merged

swarm-derive/: Derive Debug for generated OutEvent #2821

merged 4 commits into from Aug 17, 2022

Commits on Aug 16, 2022

  1. swarm-derive/: Derive Debug for generated OutEvent 

    When generating an `OutEvent` `enum` definition for a user, derive `Debug`
for that `enum`.

Why not derive `Clone`, `PartialEq` and `Eq` for the generated `enum`
definition?

While I think it is fine to require all sub-`OutEvent`s to implement
`Debug`, I don't think the same applies to traits like `Clone`. I
suggest users that need `Clone` to define their own `OutEvent`.
    @mxinden
    mxinden committed Aug 16, 2022
    Copy the full SHA
    9ba6a6e View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Merge branch 'master' of https://github.com/libp2p/rust-libp2p into d… 

    …erive-enum-debug
    @mxinden
    mxinden committed Aug 17, 2022
    Copy the full SHA
    79f49b1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into derive-enum-debug

    @mxinden
    mxinden committed Aug 17, 2022
    Copy the full SHA
    93d7330 View commit details
    Browse the repository at this point in the history

  3. swarm-derive/tests: Require Debug for OutEvent

    @mxinden
    mxinden committed Aug 17, 2022
    Copy the full SHA
    06fabf0 View commit details
    Browse the repository at this point in the history