-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/muxing: Have functions on StreamMuxer
take Pin<&mut Self>
#2765
Merged
Commits on Jul 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 01eef20 - Browse repository at this point
Copy the full SHA 01eef20View commit details -
Have functions on
StreamMuxer
usePin<&mut Self>
This is the idiomatic way of defining `poll`-based interfaces in Rust despite introducing a bit of inconvenience. To work around this inconvenience, we also introduce a `StreamMuxerExt` trait allows for better integration with async-await style code and adds a `_unpin` variant to for each `poll` function of the `StreamMuxer`.
Configuration menu - View commit details
-
Copy full SHA for 1096976 - Browse repository at this point
Copy the full SHA 1096976View commit details -
Remove
Mutex
fromlibp2p-yamux
implementationNow that the `StreamMuxer` interface has `Pin<&mut Self>` receivers, we can drop the `Mutex` from the yamux implementation.
Configuration menu - View commit details
-
Copy full SHA for df3b797 - Browse repository at this point
Copy the full SHA df3b797View commit details
Commits on Jul 23, 2022
-
Co-authored-by: Elena Frank <elena.frank@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for f16ee15 - Browse repository at this point
Copy the full SHA f16ee15View commit details
Commits on Jul 25, 2022
-
Have
StreamMuxerExt::close
consumeself
The muxer is useless after polling `poll_close` to completion, thus we can consume `self` in the extension trait method which allows us to use the function within `libp2p_swarm::Connection`.
Configuration menu - View commit details
-
Copy full SHA for cebef85 - Browse repository at this point
Copy the full SHA cebef85View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3d69d9 - Browse repository at this point
Copy the full SHA c3d69d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b82ff48 - Browse repository at this point
Copy the full SHA b82ff48View commit details
Commits on Jul 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 576a5be - Browse repository at this point
Copy the full SHA 576a5beView commit details -
Configuration menu - View commit details
-
Copy full SHA for de71a9d - Browse repository at this point
Copy the full SHA de71a9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0af6aff - Browse repository at this point
Copy the full SHA 0af6affView commit details -
Configuration menu - View commit details
-
Copy full SHA for f07746c - Browse repository at this point
Copy the full SHA f07746cView commit details
Commits on Aug 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 63c90ef - Browse repository at this point
Copy the full SHA 63c90efView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.