Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocols/gossipsub: Fix a typo in error message #2739

Merged
merged 2 commits into from Jun 30, 2022
Merged

protocols/gossipsub: Fix a typo in error message #2739

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af16251
protocols/gossipsub: Fix a typo in error message
ackintosh Jun 29, 2022
a055504
protocols/gossipsub: Make the error message accurately
ackintosh Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocols/gossipsub/src/behaviour.rs
View file
Open in desktop
Expand Up @@ -1528,7 +1528,7 @@ where
)
.is_err()
{
error!("Failed to send graft. Message too large");
error!("Failed to send PRUNE. Message too large");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Message to large" really the only failure mode here? That is not obvious from just checking is_err?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. 馃挕 I'll update this.

}
debug!("Completed GRAFT handling for peer: {}", peer_id);
Expand Down