Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/muxing: Remove deprecated function #2665

Merged
merged 2 commits into from May 23, 2022
Merged

core/muxing: Remove deprecated function #2665

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0c6cd2
Remove deprecated function
thomaseizinger May 15, 2022
279925e
Update core/CHANGELOG.md
mxinden May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions core/CHANGELOG.md
View file
Open in desktop
@@ -1,6 +1,7 @@
# 0.33.0 [unreleased]

- Have methods on `Transport` take `&mut self` instead of `self`. See [PR 2529].
- Remove deprecated function `StreamMuxer::is_remote_acknowledged`

[PR 2529]: https://github.com/libp2p/rust-libp2p/pull/2529
mxinden marked this conversation as resolved.
Show resolved Hide resolved

Expand Down
11 changes: 0 additions & 11 deletions core/src/muxing.rs
View file
Open in desktop
Expand Up @@ -203,17 +203,6 @@ pub trait StreamMuxer {
/// Destroys a substream.
fn destroy_substream(&self, s: Self::Substream);

/// Returns `true` if the remote has shown any sign of activity after the muxer has been open.
///
/// For optimisation purposes, the connection handshake of libp2p can be very optimistic and is
/// allowed to assume that the handshake has succeeded when it didn't in fact succeed. This
/// method can be called in order to determine whether the remote has accepted our handshake or
/// has potentially not received it yet.
#[deprecated(note = "This method is unused and will be removed in the future")]
fn is_remote_acknowledged(&self) -> bool {
true
}

/// Closes this `StreamMuxer`.
///
/// After this has returned `Poll::Ready(Ok(()))`, the muxer has become useless. All
Expand Down