New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protocols/autonat: optionally use only global IPs #2618
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3a214d7
protocols/autonat: add only_global_ips config
elenaf9 dedb309
protocols/autonat: fix tests and fmt
elenaf9 3df7e84
Merge branch 'master' into autonat/config-global-ips
elenaf9 a9e64da
Merge branch 'master' of github.com:libp2p/rust-libp2p into autonat/c…
elenaf9 099b258
autonat: literal copy of fns from std::net
elenaf9 f2a51f3
Merge branch 'master' of github.com:libp2p/rust-libp2p into autonat/c…
elenaf9 9c2d901
autonat: literal copy of fns from std Ipv6Addr
elenaf9 b0f9713
autonat: return DialRefused on relayed/ private ip
elenaf9 99fec62
autonat: test only_global_ips config
elenaf9 d3d9015
autonat: remove unneeded explicit `drop`
elenaf9 05d5f2d
autonat: remove outdated comment
elenaf9 5b3b909
autonat: add changelog entry
elenaf9 f7d47da
autonat: fix changelog entry
elenaf9 b5a2c46
Merge branch 'master' into autonat/config-global-ips
elenaf9 2954c1a
autonat: remove redundant check
elenaf9 7035422
autonat: return DialRefused if no dialable addrs
elenaf9 f027e09
Merge branch 'master' into autonat/config-global-ips
elenaf9 202e0ad
autonat: fix typo
elenaf9 1d6dbeb
Merge branch 'master' into autonat/config-global-ips
elenaf9 36665ee
Merge branch 'master' into autonat/config-global-ips
elenaf9 54c9681
protocols/autonat: fix typo in changelog
elenaf9 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the go implementation returns a
ResponseError::DialError
here (but with the same status text). I decided to change it here because imo aDialRefused
makes more sense. A client should not flip their status to private or reduce the confidence in their public status just because they accidentally picked a server that rejects them because of the observed address (though if the client also enabledonly_global_ips
this should not happen in practice).Edit: should it be part of the spec to list the cases in which a server returns
DialError
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think this is worth consolidating on. Mind driving it on libp2p/specs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened libp2p/specs#411.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added 7035422, which does the same change for the case that
filter_valid_addrs
filters out all addresses send from the client.