Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Error Types of Relay and DCUtR #2586

Closed
wants to merge 7 commits into from

Conversation

canewsin
Copy link
Contributor

This Exposure is required for passing swarm event to handler methods, instead dealing them at one place.

event = swarm1.select_next_some() => {
      match event {
                 event =>  DecentNetworkBehaviour::handle_swarm_event(&mut swarm1, event, &client_config1)
     }
}

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. One comment. Also missing changelog entries in protocols/dcutr/changelog.md and protocols/relay/changelog.md.

protocols/relay/src/v2.rs Outdated Show resolved Hide resolved
@canewsin
Copy link
Contributor Author

Thanks for the patch. One comment. Also missing changelog entries in protocols/dcutr/changelog.md and protocols/relay/changelog.md.

@mxinden
Should I add change log under unreleased versions for each protocol?

@mxinden
Copy link
Member

mxinden commented Mar 27, 2022

Should I add change log under unreleased versions for each protocol?

Yes please. See https://github.com/libp2p/rust-libp2p/blob/master/docs/release.md

@canewsin
Copy link
Contributor Author

@mxinden 👍

@mxinden
Copy link
Member

mxinden commented Apr 4, 2022

Merged via #2605. Thanks @canewsin!

@mxinden mxinden closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants