Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocols/identify Check multiaddr has valid peer id component prior to caching #2338

Merged
merged 3 commits into from
Nov 16, 2021
Merged

protocols/identify Check multiaddr has valid peer id component prior to caching #2338

merged 3 commits into from
Nov 16, 2021

Commits on Nov 15, 2021

  1. Check multiaddr has valid peer id component. 

    ... or none at all. We don't want to cache a multiaddr with a purposely
wrong multiaddr. e.g. something that ends with .../p2p/some-other-peer.
While this should fail to dial because we [check this before
dialing](https://github.com/libp2p/rust-libp2p/blob/master/core/src/connection/pool/concurrent_dial.rs#L144),
it's probably better to not cache this in the first place.
    @MarcoPolo
    MarcoPolo committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    72637dc View commit details
    Browse the repository at this point in the history

  2. Filter multiaddrs from info

    @MarcoPolo
    MarcoPolo committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    ac26883 View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @MarcoPolo
    MarcoPolo committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    314c0f0 View commit details
    Browse the repository at this point in the history