Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/gossipsub: Add mesh metrics #2316

Merged
merged 25 commits into from
Nov 16, 2021
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
93a7592
misc/metrics: Add support for libp2p-gossipsub
mxinden Oct 6, 2021
94e62e0
wip
divagant-martian Oct 27, 2021
c0d6f2d
wip
divagant-martian Oct 27, 2021
2f142e8
wip
divagant-martian Oct 28, 2021
614c93a
fix clippy
divagant-martian Oct 28, 2021
783a00e
Merge branch 'master' into gossip-mesh-metrics
divagant-martian Oct 28, 2021
316408d
wip
divagant-martian Oct 28, 2021
2f7ac02
fix clippy
divagant-martian Oct 29, 2021
b07772a
Merge branch 'libp2p-metrics-gossipsub' into gossip-mesh-metrics
divagant-martian Oct 29, 2021
cafbfd6
fix mod declaration order
divagant-martian Oct 29, 2021
dd5589d
fix import style
divagant-martian Oct 29, 2021
525d6f2
remove public access to metrics
divagant-martian Oct 29, 2021
96412dc
self review
divagant-martian Oct 29, 2021
d390408
remove public access metrics methods
divagant-martian Oct 29, 2021
b681a5e
update default constant name and docs
divagant-martian Oct 31, 2021
84471cb
max review comments
divagant-martian Oct 31, 2021
fbbc604
ensure max limit is respected
divagant-martian Oct 31, 2021
b5cd4f5
merge latest upstream master
divagant-martian Nov 3, 2021
d13dfa6
add msg sent metrics (#159)
divagant-martian Nov 4, 2021
9dac2d9
Merge branch 'master' into gossip-mesh-metrics
mxinden Nov 11, 2021
98c6659
add Changelog entries bumping misc/metrics version
divagant-martian Nov 15, 2021
8ec20aa
Merge branch 'master' into gossip-mesh-metrics
divagant-martian Nov 15, 2021
cde1f5b
Max likes final punctuation.
divagant-martian Nov 15, 2021
9015772
Merge branch 'master' into gossip-mesh-metrics
divagant-martian Nov 15, 2021
996d8ed
Merge branch 'master' into gossip-mesh-metrics
mxinden Nov 16, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ dns-tokio = ["libp2p-dns", "libp2p-dns/tokio"]
floodsub = ["libp2p-floodsub"]
identify = ["libp2p-identify", "libp2p-metrics/identify"]
kad = ["libp2p-kad", "libp2p-metrics/kad"]
gossipsub = ["libp2p-gossipsub"]
gossipsub = ["libp2p-gossipsub", "libp2p-metrics/gossipsub"]
metrics = ["libp2p-metrics"]
mdns = ["libp2p-mdns"]
mplex = ["libp2p-mplex"]
Expand Down
2 changes: 2 additions & 0 deletions misc/metrics/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@ keywords = ["peer-to-peer", "libp2p", "networking"]
categories = ["network-programming", "asynchronous"]

[features]
gossipsub = ["libp2p-gossipsub"]
identify = ["libp2p-identify"]
kad = ["libp2p-kad"]
ping = ["libp2p-ping"]

[dependencies]
libp2p-core= { version = "0.30.0", path = "../../core" }
libp2p-gossipsub = { version = "0.33.1", path = "../../protocols/gossipsub", optional = true }
libp2p-identify = { version = "0.31.0", path = "../../protocols/identify", optional = true }
libp2p-kad = { version = "0.33.0", path = "../../protocols/kad", optional = true }
libp2p-ping = { version = "0.31.0", path = "../../protocols/ping", optional = true }
Expand Down
52 changes: 52 additions & 0 deletions misc/metrics/src/gossipsub.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
// Copyright 2021 Protocol Labs.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the "Software"),
// to deal in the Software without restriction, including without limitation
// the rights to use, copy, modify, merge, publish, distribute, sublicense,
// and/or sell copies of the Software, and to permit persons to whom the
// Software is furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
// DEALINGS IN THE SOFTWARE.

use open_metrics_client::metrics::counter::Counter;
use open_metrics_client::registry::Registry;

pub struct Metrics {
messages: Counter,
}

impl Metrics {
pub fn new(registry: &mut Registry) -> Self {
let sub_registry = registry.sub_registry_with_prefix("gossipsub");

let messages = Counter::default();
sub_registry.register(
"messages",
"Number of messages received",
Box::new(messages.clone()),
);

Self { messages }
}
}

impl super::Recorder<libp2p_gossipsub::GossipsubEvent> for super::Metrics {
fn record(&self, event: &libp2p_gossipsub::GossipsubEvent) {
match event {
libp2p_gossipsub::GossipsubEvent::Message { .. } => {
self.gossipsub.messages.inc();
}
_ => {}
}
}
}
6 changes: 6 additions & 0 deletions misc/metrics/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
//!
//! See `examples` directory for more.

#[cfg(feature = "gossipsub")]
mod gossipsub;
#[cfg(feature = "identify")]
mod identify;
#[cfg(feature = "kad")]
Expand All @@ -37,6 +39,8 @@ use open_metrics_client::registry::Registry;

/// Set of Swarm and protocol metrics derived from emitted events.
pub struct Metrics {
#[cfg(feature = "gossipsub")]
gossipsub: gossipsub::Metrics,
#[cfg(feature = "identify")]
identify: identify::Metrics,
#[cfg(feature = "kad")]
Expand All @@ -58,6 +62,8 @@ impl Metrics {
pub fn new(registry: &mut Registry) -> Self {
let sub_registry = registry.sub_registry_with_prefix("libp2p");
Self {
#[cfg(feature = "gossipsub")]
gossipsub: gossipsub::Metrics::new(sub_registry),
#[cfg(feature = "identify")]
identify: identify::Metrics::new(sub_registry),
#[cfg(feature = "kad")]
Expand Down
2 changes: 2 additions & 0 deletions protocols/gossipsub/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ regex = "1.4.0"
futures-timer = "3.0.2"
pin-project = "1.0.8"
instant = "0.1.11"
# Metrics dependencies
open-metrics-client = "0.12"

[dev-dependencies]
async-std = "1.6.3"
Expand Down