Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: patch prost / prost-build version to v0.8 #2126

Merged
merged 1 commit into from Jul 9, 2021
Merged

*: patch prost / prost-build version to v0.8 #2126

merged 1 commit into from Jul 9, 2021

Conversation

elenaf9
Copy link
Contributor

@elenaf9 elenaf9 commented Jul 9, 2021 •
edited

Update prost and prost-build from v0.7 to v0.8.
prost-build v0.7 depends on outdated version of prost-types with the issue tokio-rs/prost#438:

Conversion from prost_types::Timestamp to SystemTime can cause an overflow and panic

cc: iotaledger/stronghold.rs#228

mxinden
mxinden approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elenaf9!

@mxinden mxinden merged commit 99da27b into libp2p:master Jul 9, 2021
@elenaf9 elenaf9 deleted the patch/prost-v0.8 branch July 9, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elenaf9 @mxinden