misc/mdns: Make MdnsService::new sync by using std::net::UdpSocket::bind #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MdnsService uses an IP address to create a UDP socket. The address does not need to be resolved. Therefore one can use std's UdpSocket::bind instead of the async counterpart from async-std. As a result MdnsService::new and MdnsService::silent don't need to be async.
tomaka
approved these changes
Jan 9, 2020
twittner
reviewed
Jan 9, 2020
misc/mdns/src/behaviour.rs
Outdated
| @@ -90,7 +90,7 @@ impl<TSubstream> Mdns<TSubstream> { | |||
| /// Builds a new `Mdns` behaviour. | |||
| pub async fn new() -> io::Result<Mdns<TSubstream>> { | |||
There was a problem hiding this comment.
Suggested change
| pub async fn new() -> io::Result<Mdns<TSubstream>> { | |
| pub fn new() -> io::Result<Mdns<TSubstream>> { |
?
There was a problem hiding this comment.
Right. That makes a lot of sense. Thanks.
|
Looks good to me, other than @twittner's correction. |
|
Should we merge this after we released |
We've already got a few breaking changes in, so let's go ahead with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MdnsService uses an IP address to create a UDP socket. The address does
not need to be resolved. Therefore one can use std's UdpSocket::bind
instead of the async counterpart from async-std. As a result
MdnsService::new and MdnsService::silent don't need to be async.
#1328 (comment)
(//CC @demimarie-parity)