Several changes. #1353
Merged
Several changes. #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pin `futures_codec` to version 0.3.3 as later versions require at least bytes-0.5 which he have not upgraded to yet. - Replace `futures::executor::block_on` with `async_std::task::block_on` where `async-std` is already a dependency to work around an issue with `park`/`unpark` behaviour. - Use the published version of `quicksink`.
This removes the last dependencies to futures-preview.
@twittner I am curious. Can you add a link to the issue? |
|
Skip over empty messages or else the socket may not be connected by the time `close` is called on it.
Demi-Marie
approved these changes
Dec 20, 2019
|
@tomaka can you merge this? |
mxinden
approved these changes
Dec 20, 2019
Except for `multiaddr` which encapsulates its use of bytes v0.4 now.
Demi-Marie
approved these changes
Dec 21, 2019
This was referenced Jan 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PinUpdate tofutures_codecto version 0.3.3 as later versions require at leastbytes-0.5which he have not upgraded to yet.bytesv0.5 except formultiaddr.futures::executor::block_onwithasync_std::task::block_onwhereasync-stdis already a dependency to work around an issue withpark/unparkbehaviour.quicksink,sokettoandyamux.futures-timerversion 2 incorewhich removes the last (transitive) dependency tofutures-preview.Depends on paritytech/unsigned-varint#23.