Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rendezvous: emit ToSwarm::NewExternalAddrOfPeer #5105

Open
thomaseizinger opened this issue Jan 21, 2024 · 4 comments · May be fixed by #5138
Open

rendezvous: emit ToSwarm::NewExternalAddrOfPeer #5105

thomaseizinger opened this issue Jan 21, 2024 · 4 comments · May be fixed by #5138
Labels
difficulty:easy help wanted

Comments

@thomaseizinger
Copy link
Contributor

Description

With #4371 merged, we have the foundation of #4302 implemented.

libp2p-rendezvous needs to be extended to emit this new event whenever it discovers a new address of a peer from a rendezvous point.

Motivation

Other behaviours should be able to learn addresses of peers from the rendezvous behaviour.

Current Implementation

Only the rendezvous behaviours learns the addresses.

Are you planning to do it yourself in a pull request ?

No
@dariusc93
Copy link
Contributor

Once the PR is merge (its not merged as of this comment) i can tackle this and the other later this week if nobody else have by then

@thomaseizinger
Copy link
Contributor Author

Yeah I am not sure what is going on with CI at the moment.

@dariusc93
Copy link
Contributor

I see it was merged so ill would like to tackle this one (will do the other one in a separate pr if nobody else wish to do it)

@thomaseizinger
Copy link
Contributor Author

I see it was merged so ill would like to tackle this one (will do the other one in a separate pr if nobody else wish to do it)

Somebody is working on mDNS and kad.

@dariusc93 dariusc93 linked a pull request Feb 2, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rz): emit NewExternalAddrOfPeer when discovering peers dariusc93/rust-libp2p
2 participants
@dariusc93 @thomaseizinger