Skip to content

Commit

Permalink
protocols/kad: Populate the key field to fix go-libp2p interop (#2309)
Browse files Browse the repository at this point in the history
populate the `key` field when converting `kadrequestmsg::putvalue` to
`proto::message`.

Co-authored-by: Max Inden <mail@max-inden.de>
  • Loading branch information
pradt2 and mxinden committed Oct 30, 2021
1 parent 06c339c commit 7c2253d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions protocols/kad/CHANGELOG.md
Expand Up @@ -6,8 +6,11 @@
`InboundPutRecordRequest` into `InboundRequest::PutRecord` and `InboundAddProviderRequest` into
`InboundRequest::AddProvider` (see [PR 2297]).

- Populate the `key` field when converting `KadRequestMsg::PutValue` to `proto::Message` (see [PR 2309]).

[PR 2245]: https://github.com/libp2p/rust-libp2p/pull/2245
[PR 2297]: https://github.com/libp2p/rust-libp2p/pull/2297
[PR 2309]: https://github.com/libp2p/rust-libp2p/pull/2309

# 0.32.0-rc.2 [2021-10-15]

Expand Down
1 change: 1 addition & 0 deletions protocols/kad/src/protocol.rs
Expand Up @@ -378,6 +378,7 @@ fn req_msg_to_proto(kad_msg: KadRequestMsg) -> proto::Message {
},
KadRequestMsg::PutValue { record } => proto::Message {
r#type: proto::message::MessageType::PutValue as i32,
key: record.key.to_vec(),
record: Some(record_to_proto(record)),
..proto::Message::default()
},
Expand Down

0 comments on commit 7c2253d

Please sign in to comment.