core/: Add Display implementation for DialError (#2473)

Co-authored-by: Frederik Baetens <baetens.fr@gmail.com>
libp2p · Feb 3, 2022 · 1b6ffb1 · 1b6ffb1
1 parent 3f4dbb1
commit 1b6ffb1
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -45,6 +45,7 @@
 ## Version 0.43.0 [unreleased]
 
 - Update individual crates.
+  - `libp2p-core`
   - `libp2p-gossipsub`
   - `libp2p-metrics`
 

diff --git a/Cargo.toml b/Cargo.toml
@@ -77,7 +77,7 @@ instant = "0.1.11" # Explicit dependency to be used in `wasm-bindgen` feature
 lazy_static = "1.2"
 
 libp2p-autonat = { version = "0.1.0", path = "protocols/autonat", optional = true }
-libp2p-core = { version = "0.31.0", path = "core",  default-features = false }
+libp2p-core = { version = "0.31.1", path = "core",  default-features = false }
 libp2p-floodsub = { version = "0.33.0", path = "protocols/floodsub", optional = true }
 libp2p-gossipsub = { version = "0.36.0", path = "./protocols/gossipsub", optional = true }
 libp2p-identify = { version = "0.33.0", path = "protocols/identify", optional = true }

diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md
@@ -1,3 +1,9 @@
+# 0.31.1 [unreleased]
+
+- Implement `Display` on `DialError`. See [PR 2456].
+
+[PR 2456]: https://github.com/libp2p/rust-libp2p/pull/2456
+
 # 0.31.0 [2022-01-27]
 
 - Update dependencies.

diff --git a/core/Cargo.toml b/core/Cargo.toml
@@ -3,7 +3,7 @@ name = "libp2p-core"
 edition = "2021"
 rust-version = "1.56.1"
 description = "Core traits and structs of libp2p"
-version = "0.31.0"
+version = "0.31.1"
 authors = ["Parity Technologies <admin@parity.io>"]
 license = "MIT"
 repository = "https://github.com/libp2p/rust-libp2p"

diff --git a/core/src/network.rs b/core/src/network.rs
@@ -572,12 +572,16 @@ impl NetworkConfig {
 #[derive(Debug, Clone, Error)]
 pub enum DialError<THandler> {
     /// The dialing attempt is rejected because of a connection limit.
+    #[error("The dialing attempt was rejected because of a connection limit: {limit}")]
     ConnectionLimit {
         limit: ConnectionLimit,
         handler: THandler,
     },
     /// The dialing attempt is rejected because the peer being dialed is the local peer.
+    #[error("The dialing attempt was rejected because the peer being dialed is the local peer")]
     LocalPeerId { handler: THandler },
+    /// The dialing attempt is rejected because the PeerId is invalid.
+    #[error("The dialing attempt was rejected because a valid PeerId could not be constructed from: {multihash:?}")]
     InvalidPeerId {
         handler: THandler,
         multihash: Multihash,