Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when creating dial targets, encapsulate PeerIds last #1389

Merged
merged 1 commit into from
Sep 23, 2022

Commits on Sep 22, 2022

  1. fix: when creating dial targets, encapsulate PeerIds last

    It turns out because `Multiaddr.encapsulate` stringifies the `Multiaddr`
    it's a [suprisingly expensive operation](multiformats/js-multiaddr#275 (comment))
    so here we switch the order of our `Multiaddr` pipeline around so
    we filter undialable addresses (e.g. unsupported transports etc) before
    encapsulating the `PeerId` onto a `Multiaddr` we'd then just ignore.
    achingbrain committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    8540b50 View commit details
    Browse the repository at this point in the history