Minimal write coalescing #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/minimal-write-coalescing
branch
from
523fc5e
to
a9143d7
Compare
|
Based on-top-of #71. |
|
Motivation: reduces the impact of #70. |
This won't coalesce with a delay, but will coalesce writes from multiple streams and/or pings if they're available at the same time.
marten-seemann
force-pushed
the
feat/minimal-write-coalescing
branch
from
a9143d7
to
6f208a8
Compare
|
Rebased on top of master, now that #71 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables minimal write coalescing but without introducing an actual delay. This will help us coalesce pings, writes on multiple streams, etc, when under load.