quic virtual listener: don't panic when quic-go's accept call errors #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
reviewed
May 8, 2023
| @@ -68,6 +69,11 @@ func (r *acceptLoopRunner) RmAcceptForVersion(v quic.VersionNumber) { | |||
| r.muxerMu.Lock() | |||
| defer r.muxerMu.Unlock() | |||
|
|
|||
| if r.muxerClosed { | |||
| // Already closed, all versions are removed | |||
There was a problem hiding this comment.
Is this an error-specific closing that basically indicates a failed start? If so maybe document/name it like that.
If so, does this mean that Accept should be modified as well? Want to make sure we don't end up in a position where we can keep calling accept but not RmAccept.
There was a problem hiding this comment.
We see the situation that quic-go's Accept sometimes errors on Windows machines. It might or might not be related to quic-go/quic-go#1737. I don't have a Windows machine, so I can't really debug this. Also, I care more about other OSes ;)
There should probably be some logging, but I'm fine adding this in a later PR.
marten-seemann
approved these changes
May 9, 2023
marten-seemann
changed the title
marten-seemann
pushed a commit
that referenced
this pull request
May 9, 2023
marten-seemann
pushed a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2259
This doesn't add any extra logging. That's a bit bigger of a change so I'll do that in another PR.