Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: don't send detailed error messages when closing connections #2112

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

marten-seemann
Copy link
Contributor

Fixes #1928.

I know this PR will make some people unhappy, but we really shouldn't send the peer a detailed error message here, as this might allow an attacker to gain a lot of insight into how a node under attack is coping with the attack. This error message has proved useful in debugging recent incidents on the IPFS network, but ultimately it's the wrong solution to the problem.
For example:

  • it only works on QUIC
  • and only for errors that occur during connection setup

Instead, we should have error codes: libp2p/specs#479

Copy link
Contributor

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "from remote" change is in quic-go, correct? Is that still planned?

@marten-seemann
Copy link
Contributor Author

The "from remote" change is in quic-go, correct? Is that still planned?

I don't know if that will actually be very helpful, once the long and confusing error message is gone.

@marten-seemann marten-seemann merged commit d686dbc into master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quic: Error from peer should be explicit that it is coming from remote peer rather than a local error
2 participants