Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basichost: don't wait for Identify before returning host.Connect #1817

Closed
wants to merge 1 commit into from
Closed

basichost: don't wait for Identify before returning host.Connect #1817

wants to merge 1 commit into from

Conversation

marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann commented Oct 9, 2022 •
edited

This saves us one RTT, at least until we've fully implemented #1807.

@marten-seemann
Copy link
Contributor Author

This is messy. The libp2p.Host doesn't expose IDService, as the BasicHost does, so it's not clear how users would wait for identify to finish. Furthermore, Connect doesn't return a connection, which would be required so what they could pass it into IdentifyWait.

@marten-seemann
Copy link
Contributor Author

Superseded by #2551.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marten-seemann