Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky resource manager tests #1315

Merged
merged 1 commit into from Feb 6, 2022
Merged

fix flaky resource manager tests #1315

merged 1 commit into from Feb 6, 2022

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Feb 6, 2022

Closes #1311

marten-seemann
marten-seemann approved these changes Feb 6, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of the Done, but it's in test code, so let's fix that flaky test.

@vyzo vyzo merged commit f2fa0b6 into master Feb 6, 2022
@vyzo vyzo deleted the fix/flaky-rcmgr-test branch February 6, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky TestResourceManagerServicePeerInbound test
2 participants
@vyzo @marten-seemann